View Issue Details

IDProjectCategoryLast Update
0023962AI War 2GUIDec 15, 2021 10:41 pm
ReporterAsteroid Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product Version2.612 Divide By Zero Hotfix 
Summary0023962: R-view shows ARS as having 5x multiplier vs Orbital Mass Driver
DescriptionFirst anomaly in the title.
Second anomaly, the ARS is also bolded which is supposed to mean it's in the local system - but there's no ARS in Mesa.
Third anomaly, the ARS is also listed in the list of things you can capture.

Basically, something really wonky is going on. I've also see this happen with Unarmed Guard Post being counted as on your team and having a 1x multiplier again some enemy unit.
TagsNo tags attached.

Relationships

related to 0023930 new R view thinks Astro Train Station is on my team 
related to 0022593 resolvedDaniexpert Eyebot bonus attack damage is not scaling? 
related to 0021739 new Strong Against is always "None" in C-click view for capturable fleets 
related to 0025813 resolvedChris_McElligottPark Damage multiplier tooltip quite broken 

Activities

Asteroid

Oct 12, 2020 10:29 pm

reporter  

Chris_McElligottPark

Oct 16, 2020 7:23 pm

administrator   ~0059255

I'm not sure what is happening. This was originally your code, and I'm having trouble following what is going on. I upgraded LINQ in a few ways and it's possible that there's something up with that, I'm not sure. Looking at the code, I don't see anything that jumps out at me as wrong with it, and really there's not a lot of LINQ being used here.

Asteroid

Oct 16, 2020 9:59 pm

reporter   ~0059263

I think it's probably a bug in my code that has been there from the start (sorry!). I remember Nuc Temeron reporting similar funny business a long while ago, and other people were complaining about some multipliers being inexact, too (https://steamcommunity.com/app/573410/discussions/0/1637550282076996257/ - though I did try to take mark into account). Since people are taking interest again in the feature (tip of the day added recently about R view, discussion on Discord) I thought I'd report it.

The R-view has always been more of a proof of concept that I hoped you'd pick up and implement with better knowledge of the engine, TBH. A proper implementation I had in mind before leaving development was pre-computing at load time a big table that lists the bonuses of every unit of every mark vs every unit of every mark, instead of computing this stuff every frame when the user is holding R. This way all that'd be left for the display would be determining what is in what faction and what's on the local planet, and a simple looking in the table.

Asteroid

Oct 16, 2020 10:11 pm

reporter   ~0059266

Here's the exact post by Nuc Temeron where he found out that the R-view sometimes thinks you're the AI: https://steamcommunity.com/app/573410/discussions/0/1637550282076996257/?ctp=2#c1637550282083856529

Including the Tractor Array listing a 2x bonus *facepalm*. It's funny in a way, but I wish this feature was working for players to use it, it's sorely needed.

So the most buggy part of the code is likely the one that checks which faction a unit is in, which if I remember correctly involves first checking the planet. There's always the possibility that Badger changed something with factions after I wrote the initial code... there was a lot of work done on being able to have factions on your team around that time, I think.

Chris_McElligottPark

Dec 15, 2021 10:41 pm

administrator   ~0063474

R-view should be all fixed up now.

Issue History

Date Modified Username Field Change
Oct 12, 2020 10:29 pm Asteroid New Issue
Oct 12, 2020 10:29 pm Asteroid File Added: 2020-10-12 22_22_45-AIWar2.png
Oct 12, 2020 10:29 pm Asteroid File Added: RViewDamageBonusForARS.save
Oct 16, 2020 7:23 pm Chris_McElligottPark Note Added: 0059255
Oct 16, 2020 7:48 pm Chris_McElligottPark Relationship added related to 0023930
Oct 16, 2020 9:59 pm Asteroid Note Added: 0059263
Oct 16, 2020 10:11 pm Asteroid Note Added: 0059266
Oct 16, 2020 10:29 pm Asteroid Relationship added related to 0022593
Oct 17, 2020 6:22 pm Asteroid Relationship added related to 0021739
Nov 13, 2021 9:42 am Daniexpert Relationship added related to 0025813
Dec 15, 2021 10:41 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Dec 15, 2021 10:41 pm Chris_McElligottPark Status new => resolved
Dec 15, 2021 10:41 pm Chris_McElligottPark Resolution open => fixed
Dec 15, 2021 10:41 pm Chris_McElligottPark Note Added: 0063474