View Issue Details

IDProjectCategoryLast Update
0025558AI War 2Bug - GameplaySep 23, 2021 11:29 pm
Reportervinco Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product VersionBeta 3.700 Bulk Of The Great Refactor 
Fixed in VersionBeta 3.701 Natural Object Order 
Summary0025558: Guard posts not releasing ships
DescriptionSee attached save. For the second system in a row, the guard posts are not releasing their ships when attacked, nor is the command post. Hacking still spawns ships, though.

TagsNo tags attached.

Activities

vinco

Sep 22, 2021 8:53 pm

reporter  

ArcenDebugLog.txt (932,202 bytes)
Guard posts not releasing.savemet (110 bytes)   
UK
739232991
564
VS37
<color=#66ffce>Easier </color> Full Ensemble
Difficulty 7
0
<color=#0000fb>Vinco</color>

BadgerBadger

Sep 23, 2021 1:42 am

manager   ~0062806

I did see guard posts release ships after being shot in one of my games, so it doesnt reproduce every time

Chris_McElligottPark

Sep 23, 2021 9:53 am

administrator   ~0062809

Log is surprisingly clean, I'll see if I can duplicate it.

Chris_McElligottPark

Sep 23, 2021 11:11 am

administrator   ~0062810

I can indeed duplicate it in this save -- thank you!

Chris_McElligottPark

Sep 23, 2021 11:19 am

administrator   ~0062812

Ooooof. Okay, so the bug here is something that I had wondered if it would be a problem. The neutral faction is not always faction 0 anymore. The player faction very often is, and so that's causing some random code to break when it is. In this case, there is code that says:

if ( mostAnnoyingFaction == 0 )
                return; //confusingly, we are deploying units against the Neutral Faction; this probably means that an enemy has just become our ally

The problem is, "faction 0" in that savegame is the humans!

I do not feel like dealing with this problem and all the codes whose assumptions we just broke, so I am going to fix it so that instead naturalobject is always faction 0 again. That means that a few saves like this one will be permanently broken, but that's preferable to months of off and on problems.

Chris_McElligottPark

Sep 23, 2021 11:29 pm

administrator   ~0062817

Thanks!

* Fixed an issue where NaturalObject (no owner) faction was not always set to faction index 0 anymore. This was something I was already aware of, but wasn't sure if it would be a problem.
** It turns out that this was a major problem, and would cause various ailments such as units not reacting to aggro and releasing units, to all sorts of other potentially unknown stuff. This will not fix existing 3.700 saves that had this problem, but any new saves will not have the problem.

Issue History

Date Modified Username Field Change
Sep 22, 2021 8:53 pm vinco New Issue
Sep 22, 2021 8:53 pm vinco File Added: ArcenDebugLog.txt
Sep 22, 2021 8:53 pm vinco File Added: Guard posts not releasing.save
Sep 22, 2021 8:53 pm vinco File Added: Guard posts not releasing.savemet
Sep 23, 2021 1:42 am BadgerBadger Note Added: 0062806
Sep 23, 2021 9:53 am Chris_McElligottPark Note Added: 0062809
Sep 23, 2021 11:11 am Chris_McElligottPark Note Added: 0062810
Sep 23, 2021 11:19 am Chris_McElligottPark Note Added: 0062812
Sep 23, 2021 11:29 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Sep 23, 2021 11:29 pm Chris_McElligottPark Status new => resolved
Sep 23, 2021 11:29 pm Chris_McElligottPark Resolution open => fixed
Sep 23, 2021 11:29 pm Chris_McElligottPark Fixed in Version => Beta 3.701 Natural Object Order
Sep 23, 2021 11:29 pm Chris_McElligottPark Note Added: 0062817