View Issue Details

IDProjectCategoryLast Update
0025670AI War 2Bug - GameplayOct 31, 2021 8:23 pm
Reportertom.prince Assigned Totom.prince  
Status resolvedResolutionfixed 
Product VersionBeta 3.712 Loading Hotfix 
Fixed in VersionBeta 3.742 "Classic Map" For DLC1 
Summary0025670: The second spire fleet appears at a random city, rather than at the mark 3 city.
DescriptionI noticed this while looking at the code to add new spire fleets in ''RecalculateSpireFleetsAndFlagships_MainThreadSimOnly''.

It looks like the third fleet is added at the new mark 4 city (since `forCity` is set unconditionally when a city of mark >= 4 is found. However, when looking at a mark 3 city, it is only set if there isn't already a `forCity` set, which could be a lower mark city.

I've attached a patch which ensure that the second fleet is created at a city of at least mark 3.
TagsNo tags attached.

Activities

tom.prince

Oct 17, 2021 7:12 pm

developer  

second-spire-fleet-city.patch (1,086 bytes)   
# HG changeset patch
# User Tom Prince <[email protected]>
# Date 1634512269 21600
#      Sun Oct 17 17:11:09 2021 -0600
# Node ID ec3ec55346db3da94b4b946506572e5885a56f12
# Parent  78137f5317ded8b7573bc5f417738b0203595836
Create second spire fleet at first Mark 3 city.

diff --git CodeExternal/AIWarExternalDeepProcessingCode/src/DeepInfo/DLC1/FallenSpireFactionDeepInfo.cs CodeExternal/AIWarExternalDeepProcessingCode/src/DeepInfo/DLC1/FallenSpireFactionDeepInfo.cs
--- CodeExternal/AIWarExternalDeepProcessingCode/src/DeepInfo/DLC1/FallenSpireFactionDeepInfo.cs
+++ CodeExternal/AIWarExternalDeepProcessingCode/src/DeepInfo/DLC1/FallenSpireFactionDeepInfo.cs
@@ -1800,7 +1800,7 @@ namespace Arcen.AIW2.External
                 else if ( city.CurrentMarkLevel >= 3 )
                 {
                     intendedNumberOfFleets = Math.Max( intendedNumberOfFleets, 2 );
-                    if ( forCity == null )
+                    if ( forCity == null || forCity.CurrentMarkLevel < 3)
                         forCity = city;
                 }
                 else
second-spire-fleet-city.patch (1,086 bytes)   

Issue History

Date Modified Username Field Change
Oct 17, 2021 7:12 pm tom.prince New Issue
Oct 17, 2021 7:12 pm tom.prince File Added: second-spire-fleet-city.patch
Oct 31, 2021 8:23 pm tom.prince Assigned To => tom.prince
Oct 31, 2021 8:23 pm tom.prince Status new => resolved
Oct 31, 2021 8:23 pm tom.prince Resolution open => fixed
Oct 31, 2021 8:23 pm tom.prince Fixed in Version => Beta 3.742 "Classic Map" For DLC1