View Issue Details
| ID | Project | Category | Date Submitted | Last Update | |
|---|---|---|---|---|---|
| 0012807 | Bionic Dues | GUI | Oct 2, 2013 9:47 pm | Oct 3, 2013 3:40 am | |
| Reporter | windgen | Assigned To | keith.lamothe | ||
| Status | resolved | Resolution | fixed | ||
| Product Version | 0.930 | ||||
| Fixed in Version | 0.931 Release Candidate 1 | ||||
| Summary | 0012807: Long price text causes overflow onto icons when filtering in store | ||||
| Description | See attached screenshot. Since the wrapping only occurs on four-digit prices, I'd assume it's wrapping due to running out of horizontal room. Two easy solutions: (1) Force the horizontal space reserved for each icon to be enough for the text that accompanies the icon. If you do this, you might have to worry about how the additional horizontal space may add up (if in the late-game 10 items have high costs and high attributes, you might require 3 more pixels for each, which means you need 30 pixels, which means the last icon would have to re-flow onto the next line). You might also have difficulty getting the icons to line up in columns (they line up one directly below the other as-is, if they have potentially different widths this doesn't work). The "dirty hack" version of solution (1) might be to compute the horizontal size of the largest text, then simply widen *all* the icons to that horizontal size. I really like this. Especially if you shrink each column afterwards to the minimum size needed by that column. Easy layout, no overflow, margins aren't too much wider than they need to be. (2) An alternate option would be to force there to be enough vertical space, i.e. if any item requires two lines of text, then force them all to use two lines of text. (And allocate extra vertical space to make room for the second line so it doesn't overlap the icon.) | ||||
| Tags | No tags attached. | ||||
| Internal Weight | Fix Before Major Release | ||||
|
|
|
|
|
|
|
|
For 0.931: * Fixed a bug on the store window where doing sort-and-filter for a stat could cause the text above a part to be wider than the part button and thus wrap the stat display to a second line (overlaying the part itself, and looking inconsistent with other parts that didn't wrap it); now the buttons will expand (slightly, in general) to fit the text as needed. ** If the buttons become wide enough that the display can't handle the same number of columns, the number of columns decreases accordingly. So your "dirty hack" variant of solution 1 really hit the nail on the head. I've been puzzling how to fully handle this case since I became aware of it weeks ago, as nothing seemed particularly clean. But it turns out that just measuring each bit of text and setting the per-item width on that flow-buttons control to match (every time the set of parts or filter changes) causes the flow-buttons control to handle all the other considerations automatically. Thanks! :) |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| Oct 2, 2013 9:47 pm | windgen | New Issue | |
| Oct 2, 2013 9:48 pm | windgen | File Added: bug12807.save | |
| Oct 2, 2013 9:50 pm | windgen | File Added: bug12807.png | |
| Oct 2, 2013 11:12 pm | keith.lamothe | Assigned To | => keith.lamothe |
| Oct 2, 2013 11:12 pm | keith.lamothe | Status | new => assigned |
| Oct 2, 2013 11:13 pm | keith.lamothe | Internal Weight | => Fix Before Major Release |
| Oct 2, 2013 11:13 pm | keith.lamothe | Description Updated | |
| Oct 3, 2013 3:40 am | keith.lamothe | Note Added: 0034448 | |
| Oct 3, 2013 3:40 am | keith.lamothe | Status | assigned => resolved |
| Oct 3, 2013 3:40 am | keith.lamothe | Fixed in Version | => 0.931 Release Candidate 1 |
| Oct 3, 2013 3:40 am | keith.lamothe | Resolution | open => fixed |
| Apr 14, 2014 9:28 am | Chris_McElligottPark | Category | Bug - UI => GUI |
