View Issue Details

IDProjectCategoryLast Update
0027174AI War 2GUIApr 29, 2022 1:48 pm
ReporterIthuriel0 Assigned ToNRSirLimbo  
Status resolvedResolutionfixed 
Product Version5.004 Misc Polish 
Fixed in Version5.006 End To Spontaneous Combustion 
Summary0027174: Incorrect Strength tooltips for Neinzul Clusters
DescriptionStrength estimates for Neinzul Clusters seem to be inaccurate in some cases. Considered has a strength estimate of 793 and CH2OH has a strength estimate of 966 for its Neinzul Cluster fleets, which seems dramatically off.
TagsNo tags attached.

Activities

Ithuriel0

Apr 25, 2022 7:04 pm

reporter  

Current.bak (308,001 bytes)
Current.save (308,096 bytes)
Current.savemet (85 bytes)   
CL
1021299725
1398
Dark Vikings
Random
Difficulty 8
1
<color=#007fff>Ithuriel</color>
Current.savemet (85 bytes)   

NRSirLimbo

Apr 25, 2022 7:50 pm

developer   ~0066450

* For the experimental, default-off tooltip: Fleet strength numbers now indicate not only the maximum strength of the fleet, but also the current strength and maximum amount of ships.
** This is to pin down a bug in the code which overestimates Neinzul Wild Hive drone fleet strength by potentially 2 magnitudes.

NRSirLimbo

Apr 29, 2022 1:48 pm

developer   ~0066542

* Fixed a three-pronged bug in the central strength calculation code where the planetary attack damage multiplier of the centerpiece was added up to the strength rating multiplier for DPS:
** This was wrong because if anything this should have been a multiplication, not addition.
** Additionally this was double-dipping because since the unification of the damage calculation code the relevant multipliers are all added up centrally already - though technically since there are no entities to which this would apply it flew under the radar.
** This bug only showed after some changes to planetary damage amplification made the default value FInt.One instead of FInt.Zero (before > FInt.Zero was required for this bug to appear, so now it did all the time).
*** End effect: Due to this trifecta of bugs all fleets with living centerpieces had the DPS of their members valued at 50% more for strength rating, leading to wrong values all over the place.
** While at it fixed as few other (harmless due to not having a trifecta such as this) places where the comparison to ignore was > FInt.Zero instead of != Fint.One. This should slightly improve performance.
*** This fixes the issue where fleet strength numbers were incorrect, discovered when Neinzul Clusters with all of their drones loaded had a higher strength displayed for their fleet compared to the strength loaded. It turns out the latter was correct.

* The experimental entity tooltip now also displays the maximum unit count possible in this fleet (most relevant for player and drone fleets).
** All the values (current/max strength/units) are now calculated in UI-only methods which are more expensive, but hopefully 100% accurate.

Issue History

Date Modified Username Field Change
Apr 25, 2022 7:04 pm Ithuriel0 New Issue
Apr 25, 2022 7:04 pm Ithuriel0 File Added: Current.bak
Apr 25, 2022 7:04 pm Ithuriel0 File Added: Current.save
Apr 25, 2022 7:04 pm Ithuriel0 File Added: Current.savemet
Apr 25, 2022 7:50 pm NRSirLimbo Assigned To => NRSirLimbo
Apr 25, 2022 7:50 pm NRSirLimbo Status new => assigned
Apr 25, 2022 7:50 pm NRSirLimbo Note Added: 0066450
Apr 29, 2022 1:48 pm NRSirLimbo Status assigned => resolved
Apr 29, 2022 1:48 pm NRSirLimbo Resolution open => fixed
Apr 29, 2022 1:48 pm NRSirLimbo Fixed in Version => 5.006 End To Spontaneous Combustion
Apr 29, 2022 1:48 pm NRSirLimbo Note Added: 0066542