View Issue Details
ID | Project | Category | Date Submitted | Last Update | |
---|---|---|---|---|---|
0027959 | Heart Of The Machine | Graphical Bug | Jul 30, 2023 3:52 pm | Jul 31, 2023 1:41 pm | |
Reporter | Chris_McElligottPark | Assigned To | Chris_McElligottPark | ||
Status | resolved | Resolution | fixed | ||
Fixed in Version | 0.503 The Return Of Testers! | ||||
Summary | 0027959: Note to self: experiment with fog shader optimizations. | ||||
Description | Something for much later. https://docs.google.com/document/d/1pIzIHIZ-cSh2ykODSZCbAPtScJ4Jpuu7lS3rNEHCLbc/edit#heading=h.80dmq3hf8i1i --------------- There are 4 quick optimizations you can make if the fog is used for VR or Mobile: Disable Noise calculations Disable Directional calculations Disable Skybox fog if the fog is already added to the skybox Disable Falloff which will disable all Power calculations which might be expensive on mobile or VR --------------- Note: I can get the noise out easily, but skybox fog might require me to code an adjustment to skybox shaders. Directional calculations are important so worth the cost. Falloff I am not sure, I may be able to design around that. | ||||
Tags | No tags attached. | ||||
|
Sigh, I went ahead and did this as well. I didn't want to risk things looking different later. For the record, I made more optimizations than simply using those defines, as the shader code was still doing useless work when the defines were in use. I disabled the noise calculations, which I wasn't using anyway, and also the code that calcualated their precursor data. I then also disabled falloff, which I was not using in any meaningful way; I can't tell any difference between the two options in any of the lighting models, but the lack of the pow function is a big savings. As noted, I have no intention of disabling the directional calculations. And for the skybox fog, I have no idea how to disable that and work around the artifacts it generates. I strongly suspect any workaround I implemented would be more costly than simply using that fog. |
Date Modified | Username | Field | Change |
---|---|---|---|
Jul 30, 2023 3:52 pm | Chris_McElligottPark | New Issue | |
Jul 31, 2023 1:41 pm | Chris_McElligottPark | Assigned To | => Chris_McElligottPark |
Jul 31, 2023 1:41 pm | Chris_McElligottPark | Status | new => resolved |
Jul 31, 2023 1:41 pm | Chris_McElligottPark | Resolution | open => fixed |
Jul 31, 2023 1:41 pm | Chris_McElligottPark | Fixed in Version | => 0.503 The Return Of Testers! |
Jul 31, 2023 1:41 pm | Chris_McElligottPark | Note Added: 0067860 |