View Issue Details

IDProjectCategoryLast Update
0005256Valley 1Bug - AVWW MultiplayerDec 4, 2011 3:12 pm
ReporterHyfrydle Assigned Tokeith.lamothe  
Status resolvedResolutionfixed 
Product Version0.545 
Fixed in Version0.546 
Summary0005256: Bug on finding second settlement at lvl 16
DescriptionMyself and Dizzard had played and reached level 16 when a new settlement had appeared we entered and accessed the settlement screen and this caused lots of errors in the log. Also as in the screensht below even though we had reached level 16 the settlement management interface wasn't there.

Error in AVWW multiplayer http://steamcommunity.com/id/hyfrydle/screenshot/594703803976533899

if you need more info let me know.
TagsNo tags attached.
Internal WeightFix ASAP

Activities

keith.lamothe

Dec 4, 2011 2:56 pm

administrator   ~0017663

Thanks, I see what method the null exception occurred in, though I can't get line numbers from a public build log. I can get them if I reproduce it while running in the Unity editor, though: does this reproduce if you restart the server and enter the strategy screen again? If so, can you attach the world to this mantis record? Thanks!

In the meantime I can apply some paranoia null-checks to prevent the errors, but even better is to find out what exactly is null that wasn't expected to be, as that could reveal the actual underlying problem so we can fix that.

Toll

Dec 4, 2011 3:00 pm

reporter   ~0017664

Hmm. Seems to look fine on my end... The only file updated (other than the world-files, of course) is output_log (not sure if it applies to server?), and I can't find anything funky in there. Appending it just in case though.

keith.lamothe

Dec 4, 2011 3:03 pm

administrator   ~0017665

Actually I do think I found it, for 0.546:

* Fixed a bug where viewing the strategy-map or settlement-management screens on a settlement with no npcs at all would cause null exceptions.


Of course, that leaves the question of why it would have had zero npcs. And if it didn't, then another bug must have been in play. So getting that world would help track that down.

Hyfrydle

Dec 4, 2011 3:05 pm

reporter   ~0017666

I can't reconnect for some reason and when I change the name in settings it keeps reverting back even though I click on save.

keith.lamothe

Dec 4, 2011 3:05 pm

administrator   ~0017667

@Toll: yea, the exceptions were happening in interface code. But the same method would be called on the server if the turn were ended when it computes food consumption. Of course, the bug we see here may be that while the settlement actually does have npcs (and thus the server has no trouble with that method) but the clients who connected before the revealing of that settlement have never actually been _told_ about those npcs and thus think the settlement is empty.

Toll

Dec 4, 2011 3:06 pm

reporter   ~0017668

Try reconnecting again, Hyfrydle. Just restarted the server.

Hyfrydle

Dec 4, 2011 3:07 pm

reporter   ~0017669

Last edited: Dec 4, 2011 3:09 pm

Just got back on the server and the settlement map is now fine and no errors encountered. New settlement has three npc's.

keith.lamothe

Dec 4, 2011 3:07 pm

administrator   ~0017670

@Hyfrydle: yea, that's the various disconnect bugs in 0.545; if you completely close AVWW, re-open it, change your username, and then try to reconnect it should let you in. In 0.546 none of that tomfoolery should be necessary.

keith.lamothe

Dec 4, 2011 3:09 pm

administrator   ~0017671

"Just got back on the server and the settlement map is now fine and no errors encountered."

That makes a lot of sense, actually: the when you reconnect the server sends you a whole fresh copy of the world state (not the chunks, just the macrogame and world-map stuff), including all the npc's and all the settlements and which npcs the settlements have. Do you see npcs in that settlement now?

Hyfrydle

Dec 4, 2011 3:10 pm

reporter   ~0017672

Yes three running around now.

Toll

Dec 4, 2011 3:12 pm

reporter   ~0017673

Sounds like you were spot-on with your guess then, Keith!

Issue History

Date Modified Username Field Change
Dec 4, 2011 2:49 pm Hyfrydle New Issue
Dec 4, 2011 2:49 pm Hyfrydle File Added: UnhandledErrors.txt
Dec 4, 2011 2:56 pm keith.lamothe Note Added: 0017663
Dec 4, 2011 2:56 pm keith.lamothe Internal Weight => Fix ASAP
Dec 4, 2011 2:56 pm keith.lamothe Assigned To => keith.lamothe
Dec 4, 2011 2:56 pm keith.lamothe Status new => assigned
Dec 4, 2011 3:00 pm Toll Note Added: 0017664
Dec 4, 2011 3:01 pm Toll File Added: output_log.txt
Dec 4, 2011 3:03 pm keith.lamothe Note Added: 0017665
Dec 4, 2011 3:03 pm keith.lamothe Status assigned => resolved
Dec 4, 2011 3:03 pm keith.lamothe Fixed in Version => 0.546
Dec 4, 2011 3:03 pm keith.lamothe Resolution open => fixed
Dec 4, 2011 3:05 pm Hyfrydle Note Added: 0017666
Dec 4, 2011 3:05 pm keith.lamothe Note Added: 0017667
Dec 4, 2011 3:06 pm Toll Note Added: 0017668
Dec 4, 2011 3:07 pm Hyfrydle Note Added: 0017669
Dec 4, 2011 3:07 pm keith.lamothe Note Added: 0017670
Dec 4, 2011 3:09 pm keith.lamothe Note Added: 0017671
Dec 4, 2011 3:09 pm Hyfrydle Note Edited: 0017669
Dec 4, 2011 3:10 pm Hyfrydle Note Added: 0017672
Dec 4, 2011 3:12 pm Toll Note Added: 0017673