View Issue Details

IDProjectCategoryLast Update
0018679Starward RogueNote To TestFeb 5, 2016 7:22 pm
ReporterCinth Assigned ToCinth  
Status resolvedResolutionfixed 
Product Version1.012 
Fixed in Version1.013 
Summary0018679: Risky Assassin Fix (someone with SVN)
DescriptionComment out the original Risky Assassin stuff in
Configuration\GameEntity\Dayton_Incredibilities
Configuration\EntitySystem\Dayton_EffectSystems

and add in my files to their respective folders. Use the save to test functionality.
TagsNo tags attached.

Relationships

related to 0018670 resolvedCinth Risky Assassin kills you? 

Activities

Cinth

Feb 4, 2016 7:49 pm

developer  

Risky Assassin.zip (2,325 bytes)

Cinth

Feb 4, 2016 7:50 pm

developer  

RA Test.save (81,909 bytes)

Chris_McElligottPark

Feb 4, 2016 7:56 pm

administrator   ~0045043

Made you a developer on this project so you can update statuses on these, too. :)

Cinth

Feb 4, 2016 7:58 pm

developer   ~0045044

You are seriously handing me keys to stuff.... Don't blame me if I wreck the Porche :p

Chris_McElligottPark

Feb 4, 2016 8:02 pm

administrator   ~0045045

For most things there are quite a few Undo type options in there. Short of malicious intent, you have a lot of safety features between you and the edge of the cliff. ;)

Cinth

Feb 4, 2016 8:12 pm

developer   ~0045047

Baby steps, man, baby steps. It's the whole me factor that needs to be worked on so I'm comfortable doing everything.

Chris_McElligottPark

Feb 4, 2016 8:16 pm

administrator   ~0045048

That's what outlet protectors and padding on sharp corners is for. :P

Cinth

Feb 4, 2016 8:19 pm

developer   ~0045049

In the time spent having this conversation with me, you could have checked the work and given me feedback, which would do wonders for my confidence ;)

Chris_McElligottPark

Feb 4, 2016 8:34 pm

administrator   ~0045050

It takes all of three seconds for a reply here. I've been absorbed in a different project and this pops up in my email is all.

Cinth

Feb 4, 2016 8:39 pm

developer   ~0045051

Yeah, the new hotness. I'm pretty sure it's been checked, I'm waiting on a confirmation though.

Pepisolo

Feb 5, 2016 4:22 pm

developer   ~0045057

I couldn't get the fix to work for some reason and I'm pretty stumped, now. Might be better to just wait for the new build, Cinth can then test the fix using the new option Keith added.

Cinth

Feb 5, 2016 4:24 pm

developer   ~0045058

If we are going to do that then disable Risky Assassin until the fix can go live.

Chris_McElligottPark

Feb 5, 2016 4:26 pm

administrator   ~0045059

In svn there is a new rev 2376 that you can test against, Craig -- sorry on the slow response there.

Pepisolo

Feb 5, 2016 4:42 pm

developer   ~0045061

Ah, nice. I appear to now be on the correct revision (I get the blue shield flash). I'll retest the fix.

Cinth

Feb 5, 2016 4:43 pm

developer   ~0045062

Woo hoo!

Pepisolo

Feb 5, 2016 4:54 pm

developer   ~0045063

Seems to work, just to check -- the bug was that it would take regular HP along with max HP? I tested taking the item at 4/8 HP now, and it seems to work as expected. Does this sound fixed to you, Cinth?

Cinth

Feb 5, 2016 5:43 pm

developer   ~0045064

The bug was it would kill you if you had any hull damage at all when you picked it up.

It would also leave you at 1/1 HP if you swapped it for something else later.

Now it does neither (put in Chris' test room and grab the + HP stuff and swap it around a few times).

If you'll do a solid and put it into SVN, I'll mark it fixed :)

Cinth

Feb 5, 2016 5:44 pm

developer   ~0045065

First blood!

Cinth

Feb 5, 2016 5:48 pm

developer   ~0045067

*For 1.013
Risky Assassin no longer kills you when you pick it up with hull damage.
 Risky Assassin now also will remember where your Max HP is so if you decide to swap it out later, you aren't stuck with 1/1 HP.

Pepisolo

Feb 5, 2016 5:56 pm

developer   ~0045069

Well, the not killing you if you have hull damage seems fixed. I don't quite get what's going on with the swapping thing. I'm not sure what Risky Assassin is supposed to be swappable with. Meh, probably works, and it's an improvement overall, anyway. You can test it further when the build goes live. Thanks!

Cinth

Feb 5, 2016 6:34 pm

developer   ~0045070

Incredibilities were changed to be one only sometime ago and you drop the one you had when you pick up another one (instead of stacking them).

Pepisolo

Feb 5, 2016 6:49 pm

developer   ~0045071

Ah, good to know. Just tested it, and it seems to work as expected. Nice one!

Cinth

Feb 5, 2016 6:51 pm

developer   ~0045072

Last edited: Feb 5, 2016 6:52 pm

Thanks :)

Just needs to be put in the patch notes now.


While you were going through the XML were my changes documented well enough?

Pepisolo

Feb 5, 2016 7:09 pm

developer   ~0045073

Done! Yeah, the changes were well documented. I'm still not very used to how items work, so mostly just copy and pasted it without learning what was going on. I'll pick things up when I start some item creation.

Cinth

Feb 5, 2016 7:11 pm

developer   ~0045074

I can point you around a little bit. I've played with items / mechs / rooms and modding systems.

I've picked a little bit.

Pepisolo

Feb 5, 2016 7:18 pm

developer   ~0045075

Thanks! I'll see how I get on with this new drone I'm creating. I'll ask you for tips if I get stuck.

Cinth

Feb 5, 2016 7:22 pm

developer   ~0045076

Np.

I'd use Dayton's stuff as a template and go from there (that should point you in all the right directions)

Issue History

Date Modified Username Field Change
Feb 4, 2016 7:49 pm Cinth New Issue
Feb 4, 2016 7:49 pm Cinth File Added: Risky Assassin.zip
Feb 4, 2016 7:50 pm Cinth File Added: RA Test.save
Feb 4, 2016 7:56 pm Chris_McElligottPark Note Added: 0045043
Feb 4, 2016 7:58 pm Cinth Note Added: 0045044
Feb 4, 2016 8:02 pm Chris_McElligottPark Note Added: 0045045
Feb 4, 2016 8:12 pm Cinth Note Added: 0045047
Feb 4, 2016 8:16 pm Chris_McElligottPark Note Added: 0045048
Feb 4, 2016 8:19 pm Cinth Note Added: 0045049
Feb 4, 2016 8:34 pm Chris_McElligottPark Note Added: 0045050
Feb 4, 2016 8:39 pm Cinth Note Added: 0045051
Feb 5, 2016 4:22 pm Pepisolo Note Added: 0045057
Feb 5, 2016 4:24 pm Cinth Note Added: 0045058
Feb 5, 2016 4:26 pm Chris_McElligottPark Note Added: 0045059
Feb 5, 2016 4:42 pm Pepisolo Note Added: 0045061
Feb 5, 2016 4:43 pm Cinth Note Added: 0045062
Feb 5, 2016 4:54 pm Pepisolo Note Added: 0045063
Feb 5, 2016 5:43 pm Cinth Note Added: 0045064
Feb 5, 2016 5:44 pm Cinth Note Added: 0045065
Feb 5, 2016 5:44 pm Cinth Status new => closed
Feb 5, 2016 5:44 pm Cinth Assigned To => Cinth
Feb 5, 2016 5:44 pm Cinth Resolution open => fixed
Feb 5, 2016 5:44 pm Cinth Fixed in Version => 1.013
Feb 5, 2016 5:46 pm Cinth Relationship added related to 0018670
Feb 5, 2016 5:48 pm Cinth Note Added: 0045067
Feb 5, 2016 5:48 pm Cinth Status closed => resolved
Feb 5, 2016 5:56 pm Pepisolo Note Added: 0045069
Feb 5, 2016 6:34 pm Cinth Note Added: 0045070
Feb 5, 2016 6:49 pm Pepisolo Note Added: 0045071
Feb 5, 2016 6:51 pm Cinth Note Added: 0045072
Feb 5, 2016 6:52 pm Cinth Note Edited: 0045072
Feb 5, 2016 7:09 pm Pepisolo Note Added: 0045073
Feb 5, 2016 7:11 pm Cinth Note Added: 0045074
Feb 5, 2016 7:18 pm Pepisolo Note Added: 0045075
Feb 5, 2016 7:22 pm Cinth Note Added: 0045076