View Issue Details

IDProjectCategoryLast Update
0016791Stars Beyond ReachSuggestionMay 21, 2015 8:13 pm
Reporterptarth Assigned ToChris_McElligottPark  
Status closedResolutionwon't fix 
Product Version0.823 (Resources And Natural Wonders) 
Summary0016791: ResourceAdjacencyEffectType Changes
DescriptionWith the scaling being a bit too much in 0.823, I looked into how the adjacency bonuses were working, and have a few comments that seem reasonable.

1. Simplify bonuses for the same bonus types by combining all bonuses of the same type (e.g. removing IncinerationBoost and IncinerationHugeBoost into just IncinerationBoost). Put the difference in values into BoostValue (framework is already there).
2. Scale AmountDesiredByAIType relative to the strength of BoostValue
3. Consider splitting Global (QB) bonuses from Adjacency bonuses into two different frameworks, perhaps the same framework but different subtypes.
4. Differentiate between additive and multiplicative bonuses using something like PropertyMathType.Add and PropertyMathType.Multiply.
5. Convert ResourceAdjacencyEffectType to read from excel data sheet.

Why?
Simplifies and removes many lines of redundant code.
The same framework can be used for Technology Bonuses, Social Development Bonuses, Building Bonuses, Market Item Bonuses, Racial Bonuses, Racial Treaties, and Wonder bonuses.

Why not?
I only see how things work at a very low and local level. I have no idea how this integrates and interacts at higher levels.
TagsNo tags attached.

Activities

Chris_McElligottPark

May 21, 2015 8:13 pm

administrator   ~0041032

To these:

1. It's easier to organize this way in a lot of the way.
2. That's gone.
3. These already are.
4. Global bonuses are all additive (well, almost all -- they have the capacity to vary), adjacency ones are all multiplicative (they don't have the capacity to vary, and are precalculated in a very specific way).
5. Not a real priority for me right now unfortunately, and time is incredibly short for me.

Issue History

Date Modified Username Field Change
May 21, 2015 2:01 pm ptarth New Issue
May 21, 2015 8:13 pm Chris_McElligottPark Note Added: 0041032
May 21, 2015 8:13 pm Chris_McElligottPark Status new => closed
May 21, 2015 8:13 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
May 21, 2015 8:13 pm Chris_McElligottPark Resolution open => won't fix