View Issue Details
| ID | Project | Category | Date Submitted | Last Update | |
|---|---|---|---|---|---|
| 0019358 | AI War 2 | GUI | Jan 26, 2018 12:58 pm | Jan 27, 2018 2:58 pm | |
| Reporter | Chris_McElligottPark | Assigned To | BadgerBadger | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 0.702 Activating Mk1 Grinding Machine | ||||
| Fixed in Version | 0.703 | ||||
| Summary | 0019358: Sidebar shows me enemy ships even when I can't see them. | ||||
| Description | Can you help out with that at all, Badger? Basically if you go to a planet two hops away, you see no ships (good), but you do still see their numbers and icons in the sidebar (bad). | ||||
| Tags | No tags attached. | ||||
| has duplicate | 0019113 | closed | Can't see any objects on planet |
|
|
So the obvious fix for this is in Window_InGameOutlineSidebar.cs to change public class bsOutlineItems : ImageButtonSetAbstractBase { ....... Planet planet = Engine_AIW2.Instance.NonSim_GetPlanetBeingCurrentlyViewed(); if ( !planet.HumansHaveBasicIntel ) return; to if ( planet.GameSecondLastHadVision < World_AIW2.Instance.GameSecond) return; Now when you click on a planet you don't have intel on, whatever previous sidebar you had is unchanged (just like when you tab out to the galaxy map). Does that seem like reasonable behaviour? |
|
|
Whether you're on the galaxy map or the planet view, you are logically "at" a planet, shown on the galaxy map as the one that is circled. So it makes sense that it's showing the sidebar from that planet. If you were to switch which planet the circle is on without actually going into the planet view (not even sure if that's possible), then it should update the sidebar to be that of the new planet that is circled. The same idiom holds true here, I think -- it's not that it is holding onto what you've "last seen," per se; it should be that it's showing whatever the sidebar is for the planet that is circled. And in this case there really is something to show: still showing the control groups (apparently), and anything that is of ownership NaturalObject is something I personally think should be shown, though Keith may disagree. That one is still open in a second topic. Worst case, it should be showing me nothing but my control groups, and otherwise just a blank sidebar. |
|
|
Fixed in .703. Note that the galaxy map will still display things like "ARS here" or "Black Hole Generator here" even if you don't have vision. That seems reasonable to me (I could imagine long range sensors picking that up even if you can't tell the exact layout of the enemy defenses) |
|
|
Awesome, thanks. In that case, for those ships that show on the galaxy map, I figure that they ought to show on the sidebar (and probably in the planet view itself) as well. That's a question for Keith, but I figure it helps with planning and is one of those things where consistency is nice. It doesn't feel cheaty to me. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| Jan 26, 2018 12:58 pm | Chris_McElligottPark | New Issue | |
| Jan 26, 2018 12:58 pm | Chris_McElligottPark | Status | new => assigned |
| Jan 26, 2018 12:58 pm | Chris_McElligottPark | Assigned To | => BadgerBadger |
| Jan 26, 2018 6:00 pm | BadgerBadger | Note Added: 0046754 | |
| Jan 26, 2018 7:57 pm | Chris_McElligottPark | Note Added: 0046755 | |
| Jan 27, 2018 11:45 am | BadgerBadger | Note Added: 0046757 | |
| Jan 27, 2018 11:47 am | BadgerBadger | Status | assigned => closed |
| Jan 27, 2018 11:47 am | BadgerBadger | Resolution | open => fixed |
| Jan 27, 2018 11:47 am | BadgerBadger | Fixed in Version | => 0.703 |
| Jan 27, 2018 11:50 am | BadgerBadger | Relationship added | has duplicate 0019113 |
| Jan 27, 2018 2:58 pm | Chris_McElligottPark | Note Added: 0046758 |
