View Issue Details

IDProjectCategoryLast Update
0021049AI War 2Bug - OtherApr 22, 2019 12:03 pm
ReporterRocketAssistedPuffin Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product VersionBETA 0.850 The Arrival of Fleets 
Fixed in VersionBETA 0.853 An Officer And A Bunch Of Fleets 
Summary0021049: Cannot select other fleets in lobby
DescriptionApparently you always get the Classic regardless of what you chose.
TagsNo tags attached.

Relationships

related to 0021098 resolvedChris_McElligottPark Cant start game with other ships 

Activities

Chris_McElligottPark

Apr 19, 2019 1:23 pm

administrator   ~0051194

Boy that's irritating. I really hate the lobby code, and I don't understand it at all. On a cursory look through the code, I have no idea what's wrong.

BadgerBadger

Apr 22, 2019 11:18 am

manager   ~0051270

Last edited: Apr 22, 2019 11:20 am

The code in BaseFaction.cs that should set the starting fleet is
                                case "StartingFlagship":
                                    ArcenDebugging.ArcenDebugLogSingleLine("setting the starting flagship to " + fieldValue, Verbosity.DoNotShow ); <=====
                                    faction.InitialFleet = FleetDesignTemplateTable.Instance.GetRowByName( fieldValue, false, null );
                                    FactionConfig.CustomFieldValues[field.InternalName] = faction.InitialFleet.InternalName;
                                    break;

But when I start a game, I see
4/22/2019 9:16:43 AM Generate Map with type Simple and seed 295488209
4/22/2019 9:16:43 AM World Created, Launching Server
4/22/2019 9:16:43 AM Successfully opened host socket
4/22/2019 9:16:48 AM Generate Map with type Simple and seed 295488209
4/22/2019 9:16:48 AM Generate Map Complete

Note that debug log line never happens.

At a guess, the problem is in the game lobby we say
                    switch ( field.InternalName )
....
                        case "StartingFleet":
                            AddDropdown( Set, typeof( dFleet ), tag, tabName, customDropdownRect, fontSize );
                            break;

and in the BaseFaction code we say
                    switch ( field.InternalName )
....
                                case "StartingFlagship":

The mismatched name (startingfleet vs startingflagship) is the problem.

Chris_McElligottPark

Apr 22, 2019 12:03 pm

administrator   ~0051278

Thanks!

* Fixed a bug where you could not select the starting fleet without it always just defaulting back to classic.

* Put in some fixes so that if you have invalid/mismatched options (custom or otherwise) in the lobby, it will now complain about them properly and let you know that things are failing.
** With this we found that the team colors for Instigators and the AntagonizedDysonSphere were not working properly, for instance.

Issue History

Date Modified Username Field Change
Apr 18, 2019 7:31 pm RocketAssistedPuffin New Issue
Apr 19, 2019 1:23 pm Chris_McElligottPark Note Added: 0051194
Apr 22, 2019 7:26 am RocketAssistedPuffin Relationship added related to 0021098
Apr 22, 2019 11:18 am BadgerBadger Note Added: 0051270
Apr 22, 2019 11:19 am BadgerBadger Note Edited: 0051270
Apr 22, 2019 11:20 am BadgerBadger Note Edited: 0051270
Apr 22, 2019 11:20 am BadgerBadger Assigned To => Chris_McElligottPark
Apr 22, 2019 11:20 am BadgerBadger Status new => assigned
Apr 22, 2019 12:03 pm Chris_McElligottPark Status assigned => resolved
Apr 22, 2019 12:03 pm Chris_McElligottPark Resolution open => fixed
Apr 22, 2019 12:03 pm Chris_McElligottPark Fixed in Version => BETA 0.853 An Officer And A Bunch Of Fleets
Apr 22, 2019 12:03 pm Chris_McElligottPark Note Added: 0051278