|
|
20191226175511_1.jpg (197,680 bytes) |
|
|
It IS bugged as I have had the same problem. On the same vein, mods that aren't in the loading order still load improperly. Specifically, for ships or structures that already exist the data seems to merge, regardless of the presence of partial_record expression in the code. You can end up with weapons that have the same multipliers twice for instance. Sometimes that'll have no impact but sometimes that will also lead to oddities where you can vanilla plus modded multipliers. For weapons, damage can be multiplied in some weird fashion. I have had Spire Frigate with Beam dealing over 500,000 damage at mark V despite the "Max damage for beam" being capped much lower. More recently we had a likely odd case where Golems didn't gain health and shields per mark. On a more minor note, when adding modded tech, the tech menu won't properly sort. Back when we didn't have turret tech I added mine and it was always at the bottom despite my attempts to make it appear under the Hulls tech and above defenses/command-station techs. This behavior hasn't changed in since then. That's my report on modding issue. |
|
|
Thank you! The specific mod that you have outlined here now works fine for the v-wing, and I've tested that. There are still some other cases in other reports that probably need fixing, and I'm about to look into those. Here's what I've fixed so far: * Several different things were not staying properly on ships when using an is_partial_record="true" to mod them: ** exp_to_grant_on_death ** watch_planets_at_X_hops ** tags (ow this would cause many problems) ** capturable_seed_weight (again very problematic) ** capturable_max_per_galaxy ** capturable_can_seed_at_all * Fixed a couple of things that would complain they could not be found properly on ships when using an is_partial_record="true" to mod them (but in reality these were carrying over fine from the base version being modded): ** ship_or_structure_explosion_sfx ** ship_or_structure_explosion_if_on_other_planet_sfx Specifically, this now works: <?xml version="1.0" encoding="utf-8"?> <root> <entity name="VWing" armor_mm="150" is_partial_record="true" > </entity> </root> |
|
|
Thanks! * If outgoing_damage_modifier or incoming_damage_modifier entries are duplicated in the list of rows for a system or entity (respectively), whether that be through mods or just in the original definition, it now only uses the last-to-apply version. This last-to-apply one is always going to be a mod version if there is a mod version. ** This makes it so that you can't have two different modifiers on the same weapon that both are based off of the hull health of a ship, for example, but I don't think we're doing that anywhere and it would be messy in the UI if we were, anyway. ** This then fixes the issue with various weapon bonuses and the like duplicating themselves when you are using an is_partial_record entry to mod a weapon. ** It's worth noting at this point that xml modding is inherently slightly fraught in terms of minor bugs or oversights like this which can have major repercussions. Please just let us know on a case by case basis what you find, ideally with the xml you're using and a savegame that shows the wrong behavior, and we can likely fix it up pretty fast. So now this works: <?xml version="1.0" encoding="utf-8"?> <root> <entity name="FusionBomber" armor_mm="150" is_partial_record="true" > <system name="FusionBomb"> <outgoing_damage_modifier based_on="CurrentPersonalShieldPercentage" applies_to="HullOnly" comparison_type="AtLeast" compared_to="80" multiplier="2" /> </system> </entity> </root> |
|
|
As to the tech sorting issue, that's very peculiar. I looked into possible reasons for that, and the code looks good. I revised that a lot earlier this month I think it was, so maybe it was fixed since then? If not, the xml to recreate the problem would be awesome. |
|
|
Oh, and last note on this topic -- golems not gaining health or whatever per mark is a VERY central sort of bug which means there was an issue during processing, I think. I don't think that's a real bug, but rather a sign that there was another bug that happened earlier and then the later per-mark calculations were not run. I'd need a repro case for that either, so I could fix whatever the root bug is, and then the health and shields incrementing should sort itself out. Thanks again for all the reports! Please feel free to make new ones for anything new that's coming up (or following on from these comments). |
|
|
I'm starting to get into modding the game, at least on an XML level, so if I come across anything else I know where to put it, thanks! |
|
|
Thanks very much! I was going to get this release out today, but then Puffin and I got into some craziness with AI reinforcement budgets and that's dragging into tomorrow. |
- Anonymous
