View Issue Details

IDProjectCategoryLast Update
0023154AI War 2Bug - GameplayApr 21, 2020 1:35 pm
ReporterValkyr Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product Version2.026 The Faction Duality Problem 
Fixed in VersionBeta 2.029 Journal And Faction Edit Framework 
Summary0023154: Minefield Remains
DescriptionMinefields do not die to remains, in spite of what their tooltip says.
Can replicate by taking minelayer citadel, and spawning waves into your planet.
I assume Scrap Turrets may function the same way, due to killing themselves while attacking.
TagsNo tags attached.

Activities

Valkyr

Apr 16, 2020 7:19 pm

reporter  

Mine1.png (282,113 bytes)
Mine2.png (314,964 bytes)

BadgerBadger

Apr 16, 2020 7:26 pm

manager   ~0056871

Any chance you have a save game with this problem visible?

Valkyr

Apr 16, 2020 7:32 pm

reporter   ~0056872

I would forget something. Debugged a couple waves in, the V-wings should cause one of the minefields on the path to the home citadel to finish dying when they path towards it.
Mines.save (835,705 bytes)

Strategic Sage

Apr 19, 2020 3:15 pm

reporter   ~0056911

Just seconding this, Chris was discussing it with somebody in a steam thread, and I'm now starting to see it as well (hadn't been in previous versions).

Strategic Sage

Apr 19, 2020 3:25 pm

reporter   ~0056912

… and now they are dying to remains and being rebuilt. Don't know what changed.

Chris_McElligottPark

Apr 21, 2020 1:35 pm

administrator   ~0056928

Thank you! And I'm guessing that maybe it was decloakers in your most recent game that changed things up, Strategic Sage. But not sure.

* Put in some rather substantial changes to things to now have a DamageSource Damage instead of a bool IsSelfDamage/WasFromSelfDamage.
** This now lets us differentiate the following:
*** SomeSortOfEnemy: used for any sort of external hostile weapon, attrition, or other bad thing someone else does to this unit.
**** All the normal death effects should happen, and things like being able to be regenerated by regenerators to prevent death, etc. This was already working fine.
*** SelfDamageFromMyOwnWeapons: used for any sort of self-inflicted damage, such as attrition to myself over time, or using my own health to regenerate someone else or power an explosion (minefields).
**** Some death effects should happen, but very few. Basically if I die to remains, I should go ahead and still do that (aka minefields). But beyond that, regenerators can't save me, etc.
** BeingScrapped: used for something that needs to die for some reason, and it really just needs to go. Often this is literally a player scrapping something, either directly or by swapping lines between fleets, or the AI scrapping one set of units to move them into a new stack, etc.
**** The absolute minimum case. We're supposed to DIE, so we don't even go to remains if we normally would. This last case was being used for minefields self-damaging themselves in the last few weeks for the game, and is why we had to make this a tri-state thing instead of a boolean self/other damage source. If you scrap a minefield it should not go to remains, but if it damages itself to death it should go to remains.
** Basically minefields were never going to remains recently unless enemies were decloaking them and shooting them in the final shots, or some edge case like that.

Issue History

Date Modified Username Field Change
Apr 16, 2020 7:19 pm Valkyr New Issue
Apr 16, 2020 7:19 pm Valkyr File Added: Mine1.png
Apr 16, 2020 7:19 pm Valkyr File Added: Mine2.png
Apr 16, 2020 7:26 pm BadgerBadger Note Added: 0056871
Apr 16, 2020 7:32 pm Valkyr File Added: Mines.save
Apr 16, 2020 7:32 pm Valkyr Note Added: 0056872
Apr 19, 2020 3:15 pm Strategic Sage Note Added: 0056911
Apr 19, 2020 3:25 pm Strategic Sage Note Added: 0056912
Apr 21, 2020 1:35 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Apr 21, 2020 1:35 pm Chris_McElligottPark Status new => resolved
Apr 21, 2020 1:35 pm Chris_McElligottPark Resolution open => fixed
Apr 21, 2020 1:35 pm Chris_McElligottPark Fixed in Version => Beta 2.029 Journal And Faction Edit Framework
Apr 21, 2020 1:35 pm Chris_McElligottPark Note Added: 0056928