View Issue Details

IDProjectCategoryLast Update
0023610AI War 2Bug - OtherAug 29, 2020 5:01 pm
ReporterLord Of Nothing Assigned ToChris_McElligottPark  
Status resolvedResolutionduplicate 
Product Version2.129 No Shrooms For Ships 
Fixed in Version2.130 Civilian Industries 
Summary0023610: Error message on saving. (Save still works fine.)
DescriptionI had this pop up in an otherwise unremarkable game session, upon saving. The save created is attached, this is the entirety of the debug report below.
If I figure out a reproduction I will update this - it won't reproduce from the save, of course.

8/29/2020 11:01:17 AM
Tried to write Int16 PosExceptNeg1, but passed value was: -30441, which is out of range! Value set to -1 so your save would work. FieldNameForErrors: OverrideSpeedLimit

  at System.Environment.get_StackTrace () [0x00000] in <1f0c1ef1ad524c38bbc5536809c46b48>:0
  at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.DebugLogDestination Destination, System.Boolean IncludeStackTrace, Arcen.Universal.Verbosity Verbosity) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.DebugLogDestination Destination, Arcen.Universal.Verbosity Verbosity) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.Universal.ArcenDebugging.ArcenDebugLog (System.String Message, Arcen.Universal.Verbosity Verbosity) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.Universal.ArcenSerializationBuffer.AddInt16 (Arcen.Universal.ReadStyle RStyle, System.Int16 Item, System.String FieldNameForErrors) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.AIW2.Core.SpeedGroup.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.AIW2.Core.Faction.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.AIW2.Core.World_AIW2.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.Universal.World.SerializeTo (Arcen.Universal.ArcenSerializationBuffer Buffer) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.Universal.World.SaveWorldToDisk (System.String SaveName, System.Collections.Generic.List`1[T] SavegameMetadata) [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.AIW2.External.GameCommand_SaveGame.Execute (Arcen.AIW2.Core.GameCommand command, Arcen.AIW2.Core.ArcenSimContext context) [0x00000] in <7896bea2fe8d4668a3426ffe131230ee>:0
  at Arcen.AIW2.Core.GameCommand.Execute (Arcen.AIW2.Core.ArcenSimContext Context) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.AIW2.Core.World_AIW2.OnClient_ExecuteGameCommandsReceivedFromServer (Arcen.AIW2.Core.ArcenSimContext Context) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.AIW2.External.SimPlannerImplementation.DoActualSimStep (System.Boolean& stalledWaitingOnConnections, System.Boolean& mayUpdateVisuals, System.String& reasonForNoVisualUpdates) [0x00000] in <7896bea2fe8d4668a3426ffe131230ee>:0
  at Arcen.AIW2.Core.Engine_AIW2.ProcessSimStep (System.Boolean& stalledWaitingOnConnections, System.String& reasonForNoVisualUpdates) [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at Arcen.Universal.Engine_Universal.OnUpdateFromMainThread () [0x00000] in <2ff2164184f44698aefb347e7db02c42>:0
  at Arcen.AIW2.Core.ArcenGameControllerBase.BaseUpdate () [0x00000] in <cbe4f52e1f0945939e1cf19892bce1af>:0
  at ArcenGameController.Update () [0x00000] in <342846c60ad043638e2ec80b42611e65>:0
TagsNo tags attached.

Relationships

duplicate of 0023466 resolvedChris_McElligottPark Error upon saving 
related to 0023593 resolvedChris_McElligottPark Occasional Exception 
related to 0023493 resolvedChris_McElligottPark Tried to write Int16 PosExceptNeg1, but passed value was: -31018 
related to 0023472 resolvedChris_McElligottPark Error overwriting a save - "Tried to write Int16 PosExceptNeg1..." 

Activities

Lord Of Nothing

Aug 29, 2020 6:07 am

reporter  

Quick2.savemet (96 bytes)
Quick2.save (566,239 bytes)

Chris_McElligottPark

Aug 29, 2020 5:01 pm

administrator   ~0058275

Thanks!

* It is now possible that your logs will wind up having the message "BUG: overriding speed limit for group X to [a negative number below -1]. Overflow? Setting to -1 instead."
** If this is frequent, it may slow down your game, but the stack traces will let us know where we are going wrong and causing this to happen.
** We fixed one area where MAYBE this could be caused, but probably that was not possible in the place we fixed it. Most likely the problem is in something that is calling GameCommand_CreateSpeedGroup with a command.RelatedIntegers[0] that is greater than the 32767.
*** With that in mind, anything that is larger than that being passed into that method is now automatically corrected down to 32766. This may lead to some turbo speed groups, not sure, but at least they won't be erroring... and that IS what the calling code is asking for, so maybe it's intentional?
** At the same time, in some other places in the code where it was checking to apply the speed only if it was "not -1", it is now checking to apply the speed limit if it is "greater than 0." This seems more like the correct intent, and hopefully won't break anything.
** And beyond that, prior to serialization, any speed groups with an OverrideSpeedLimit less than -1 will automatically just set their value to -1 silently and thus avoid popup errors that could be really annoying in savegames for folks. This has been an issue on and off since July 24th, apparently.

Issue History

Date Modified Username Field Change
Aug 29, 2020 6:07 am Lord Of Nothing New Issue
Aug 29, 2020 6:07 am Lord Of Nothing File Added: Quick2.savemet
Aug 29, 2020 6:07 am Lord Of Nothing File Added: Quick2.save
Aug 29, 2020 4:10 pm Chris_McElligottPark Relationship added related to 0023593
Aug 29, 2020 4:11 pm Chris_McElligottPark Relationship added related to 0023493
Aug 29, 2020 4:12 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Aug 29, 2020 4:12 pm Chris_McElligottPark Status new => assigned
Aug 29, 2020 4:13 pm Chris_McElligottPark Relationship added related to 0023472
Aug 29, 2020 4:14 pm Chris_McElligottPark Relationship added duplicate of 0023466
Aug 29, 2020 5:01 pm Chris_McElligottPark Status assigned => resolved
Aug 29, 2020 5:01 pm Chris_McElligottPark Resolution open => duplicate
Aug 29, 2020 5:01 pm Chris_McElligottPark Fixed in Version => 2.130 Civilian Industries
Aug 29, 2020 5:01 pm Chris_McElligottPark Note Added: 0058275