View Issue Details

IDProjectCategoryLast Update
0024135AI War 2Bug - OtherNov 18, 2020 2:54 pm
ReporterDaniexpert Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product Version2.633 Roaring Performance 
Fixed in Version2.634 Multiplayer Solidification 
Summary0024135: Error "600 System.Exception" spam in log
DescriptionI found in the log, after playing today, a huge spam of some thousands of linen saying the same thing during a shared player faction game:
11/18/2020 1:49:01 PM In PerSecond_UpdateFleetData, debugCode 600 System.Exception: For Viral Shredder Copy no base unit type was defined in the XML
  at Arcen.AIW2.Core.Fleet.PerSecond_UpdateFleetData (Arcen.AIW2.Core.ArcenSimContext Context) [0x000bb] in <b42976faceae4d8a913bb09053c5fbfc>:0

Yes, we were using Viral Shredders :D
TagsNo tags attached.

Activities

BadgerBadger

Nov 18, 2020 1:03 pm

manager   ~0059638

Playing with a shared player faction?

Daniexpert

Nov 18, 2020 1:09 pm

manager   ~0059639

Yes, I'll add that in the description. All the reports I'm writing today are from the shared player faction.

Chris_McElligottPark

Nov 18, 2020 2:08 pm

administrator   ~0059653

Would you mind posting the savegame that this was happening with? Are the viral shredders a mod? I can't recall at this point what is where. I thought those were just a DLC1 unit.

I'm going to do some preliminary looking at this error, but to really do much with this one I'd probably need to be able to replicate it from the save.

Chris_McElligottPark

Nov 18, 2020 2:10 pm

administrator   ~0059654

This actually looks like a legit issue that should happen on the client AND the host. Was this just on the client, or also on the host?

Daniexpert

Nov 18, 2020 2:22 pm

manager   ~0059655

I'll ask for the host's log.
The save is this one, which he sent me.
No mods. Vanilla game with DLC1 enabled.
2.save (370,466 bytes)

Chris_McElligottPark

Nov 18, 2020 2:54 pm

administrator   ~0059656

Thanks! I can verify that this now works perfectly in the next build. That will stop a lot of lag on the client, among other things!

* Some of the data for how things that use internal build points (for things like viral shredders in particular) was being set up on the fleet memberships, and cached there as well.
** Now it sets it up once only, at game start, in ComputeBalanceStats_OneTimeOnly(). This is more efficient, and also gives us errors on load if our xml is wrong, and also fixes a compatibility problem.
*** There was previously a bug in multiplayer where viral shredders would lead to endless exceptions on the client because it was missing the extra cached data on the fleetmem, ouch.
** As an additional bonus, we are no longer storing this data on fleet memberships in general, which means we no longer have to serialize and deserialize that.
*** The fact that we WERE serializing it was making the question of the exceptions in multiplayer even more confusing, but at any rate now some sync data and all savegames will be a tiny bit smaller.

* MP clients in general will no longer throw any exceptions related to things with internal build points on their fleetmems. If something is off, it will just let the host take care of that and inform them within a few seconds.
** However, the error will still happen on the host if something is messed up, but it will be more informative and not block the rest of the execution of this fleetmem per-second cycle.
** And based on the fix above, this should now just work properly in general on clients, but we prefer an abundance of caution.

Issue History

Date Modified Username Field Change
Nov 18, 2020 1:02 pm Daniexpert New Issue
Nov 18, 2020 1:03 pm BadgerBadger Note Added: 0059638
Nov 18, 2020 1:09 pm Daniexpert Note Added: 0059639
Nov 18, 2020 1:09 pm Daniexpert Description Updated
Nov 18, 2020 2:08 pm Chris_McElligottPark Note Added: 0059653
Nov 18, 2020 2:10 pm Chris_McElligottPark Note Added: 0059654
Nov 18, 2020 2:22 pm Daniexpert File Added: 2.save
Nov 18, 2020 2:22 pm Daniexpert Note Added: 0059655
Nov 18, 2020 2:54 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Nov 18, 2020 2:54 pm Chris_McElligottPark Status new => resolved
Nov 18, 2020 2:54 pm Chris_McElligottPark Resolution open => fixed
Nov 18, 2020 2:54 pm Chris_McElligottPark Fixed in Version => 2.634 Multiplayer Solidification
Nov 18, 2020 2:54 pm Chris_McElligottPark Note Added: 0059656