View Issue Details

IDProjectCategoryLast Update
0024553AI War 2Gameplay IssueMar 15, 2021 12:17 pm
ReporterBadgerBadger Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product VersionBeta 2.757 Super Mega Exciting Sidebar 
Fixed in VersionBeta 2.758 Threat Explanation 
Summary0024553: Lots of queued journals on MP client
DescriptionI'm seeing a ton of queued journal entries on my MP client

This seems like a needless use of resources
TagsNo tags attached.

Activities

BadgerBadger

Mar 13, 2021 10:05 pm

manager  

journal entry (2,411,452 bytes)

BadgerBadger

Mar 15, 2021 3:10 am

manager   ~0060774

erm. that file is a jpg missing its extension

Chris_McElligottPark

Mar 15, 2021 11:49 am

administrator   ~0060775

Are you a client, or the host?

Chris_McElligottPark

Mar 15, 2021 12:17 pm

administrator   ~0060776

Thanks! This should be solidly accident-proof in the code now for us and for mods. We had a number of oversights that would have caused lots of chaos in multiplayer with these, which is probably what you were seeing.

* QueueLogJournalEntryToSidebar() has been updated so that the old version is obsolete, and modders and similar need to update their code to use a new version that has an OnClient enum parameter.
** This new parameter generally tells the game to either ignore this on clients -- almost always a good idea, unless this is something detected only on a single client only -- or run this on the host only.
** The default for anything that is still using the deprecated versions is that it will run on the host only.
** Essentially, these are quite midsize messages that should not be going out in large batches, but sometimes were. This would potentially swamp a multiplayer game, potentially if it actually created all those journal entries at the far end (you'd have tons of duplicates and savegames would be strangely large.

* Fixed the following journal entries that were at bare minimum happening too frequently in multiplayer because client were trying to do it, but may have happened even more than that.
** First time met PG, hunter, AI reserves, warden, dark spire, astro trains, dark zenith, outguard.
** All the various astro train secondary notices.
** All of the "base lore" journals for the various races and similar.
** Imperial spire arriving, and nanocasut invasion starting.
** All of the other journal entries were fine. Things like the beginner journals, info on allies, zenith architrave stuff, extragalactic war starting, and many various other more specific situational ones were already MP-safe.

Issue History

Date Modified Username Field Change
Mar 13, 2021 10:05 pm BadgerBadger New Issue
Mar 13, 2021 10:05 pm BadgerBadger Status new => assigned
Mar 13, 2021 10:05 pm BadgerBadger Assigned To => Chris_McElligottPark
Mar 13, 2021 10:05 pm BadgerBadger File Added: journal entry
Mar 15, 2021 3:10 am BadgerBadger Note Added: 0060774
Mar 15, 2021 11:49 am Chris_McElligottPark Note Added: 0060775
Mar 15, 2021 12:17 pm Chris_McElligottPark Status assigned => resolved
Mar 15, 2021 12:17 pm Chris_McElligottPark Resolution open => fixed
Mar 15, 2021 12:17 pm Chris_McElligottPark Fixed in Version => Beta 2.758 Threat Explanation
Mar 15, 2021 12:17 pm Chris_McElligottPark Note Added: 0060776