View Issue Details

IDProjectCategoryLast Update
0025789AI War 2Crash/ExceptionNov 8, 2021 4:24 pm
ReporterMajor Dullard Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product VersionBeta 3.746 Phantom Ship Syndrome 
Fixed in VersionBeta 3.750 Smooth Simulator 
Summary0025789: loads of errors and crash
Description400+ errors and crash in the first minute of the game.
TagsNo tags attached.

Activities

Major Dullard

Nov 6, 2021 10:56 am

reporter  

ArcenDebugLog.txt (1,075,742 bytes)

Chris_McElligottPark

Nov 8, 2021 3:10 pm

administrator   ~0063247

Part 1 of the fix, thanks!

* Fixed an exception in GetShouldAttackNormallyExcludedTarget() for the nanocaust that I unintentionally introduced on October 31st when trying to prevent memory leaks and reworking the character buffer usage. In this particular case, the old code was not a memory leak, but my error in handling this was a source of infinite exceptions if you had nanocaust active.

Chris_McElligottPark

Nov 8, 2021 3:52 pm

administrator   ~0063248

Another:

* There is some sort of exception that keeps being possible in my list class when AddRange is called, which calls InsertRange, which does List.CopyTo. I think this is related to lazy-initialization, but I really can't tell what the heck is going on exactly.
** What I've done now is made it so that it gives me way more detailed information on those operations if they fail, without too much in the way of cost, since these are not really used all that frequently to where they could be THAT large of CPU drains.
** The end result of this will lead to incorrect data (aka the data won't be copied), but not an actual halt to program execution like it did previously.

Chris_McElligottPark

Nov 8, 2021 3:59 pm

administrator   ~0063249

More:

* The exception "CalculateRequestedFlows exception hit. debugCode 390" has been instrumented further to give us much more detailed data about what is wrong.
** To be honest, given the state of the log in which this was found, I think that the cross-threading issue that tom.prince found and fixed in this new version is probably going to resolve this. But just in case.

Chris_McElligottPark

Nov 8, 2021 4:01 pm

administrator   ~0063250

More:

* Same deal with "CalculateRequestedFlows exception hit. debugCode 420." It's now a lot more detailed, but probably already resolved by tom.prince's fixes.

Chris_McElligottPark

Nov 8, 2021 4:16 pm

administrator   ~0063251

Yet more:

* Updated PlannedFlowsByPlanet_Sorted_ForUI to be a bit more efficient, and a bit more error-proof during its sorts. This is a rare case where I'm actually leaning more on the GC (with a RefThreeTuple instead of a Pair) in exchange for the ability to precalculate some data that was otherwise calculated repeatedly in a loop within a sort, which is definitely a slowing sort of thing to do.

Chris_McElligottPark

Nov 8, 2021 4:24 pm

administrator   ~0063252

That finishes the last of them. Thank you!

* Altered our List.RemoveAt() code so that it now diverges from the Microsoft standard a bit more. It now takes an optional second parameter, ThrowErrors.
** If that is true, then it works like it used to -- if the code tries to remove something out of range, it will freak out and die.
** If that is false, which is the default, then the code will just silently return false. Previously it did not return anything.
** There are times where we have one thread updating a targeting list and another thread reading from it, among many other circumstances, and it was possible to get errors in these cases. Now it will just gracefully keep going, instead.

Issue History

Date Modified Username Field Change
Nov 6, 2021 10:56 am Major Dullard New Issue
Nov 6, 2021 10:56 am Major Dullard File Added: ArcenDebugLog.txt
Nov 8, 2021 3:10 pm Chris_McElligottPark Note Added: 0063247
Nov 8, 2021 3:52 pm Chris_McElligottPark Note Added: 0063248
Nov 8, 2021 3:59 pm Chris_McElligottPark Note Added: 0063249
Nov 8, 2021 4:01 pm Chris_McElligottPark Note Added: 0063250
Nov 8, 2021 4:16 pm Chris_McElligottPark Note Added: 0063251
Nov 8, 2021 4:24 pm Chris_McElligottPark Assigned To => Chris_McElligottPark
Nov 8, 2021 4:24 pm Chris_McElligottPark Status new => resolved
Nov 8, 2021 4:24 pm Chris_McElligottPark Resolution open => fixed
Nov 8, 2021 4:24 pm Chris_McElligottPark Fixed in Version => Beta 3.750 Smooth Simulator
Nov 8, 2021 4:24 pm Chris_McElligottPark Note Added: 0063252