View Issue Details

IDProjectCategoryLast Update
0021801AI War 2Bug - GameplayOct 14, 2019 1:30 pm
Reporterwm46 Assigned ToChris_McElligottPark  
Status resolvedResolutionfixed 
Product Version0.900 Custom Fleets With Empty Slots 
Fixed in Version0.950 First Press Build 
Summary0021801: The Lines generated by Claiming an entity are not visible
DescriptionProbably related to one of the changes Badger or I made to try to stop engineers from using Combat Factories while they were crippled.

Save for quick testing.
TagsNo tags attached.

Activities

wm46

Oct 13, 2019 5:10 pm

reporter  

AAA.save (432,318 bytes)

BadgerBadger

Oct 14, 2019 12:22 pm

manager   ~0053645

Last edited: Oct 14, 2019 12:23 pm

Actually the engineers are assisting, there's something wrong with the line display.

Here's some logging from Faction.cs:
10/14/2019 10:21:14 AM I have a flow from Engineer 0005583 trying to claim Backdoor Combat Factory 0003837
10/14/2019 10:21:14 AM Setting up the line; we are spending 49.9267578125 this Sim-Step
10/14/2019 10:21:14 AM I have a flow from Engineer 0005584 trying to claim Backdoor Combat Factory 0003837
10/14/2019 10:21:14 AM Setting up the line; we are spending 49.9267578125 this Sim-Step
10/14/2019 10:21:14 AM I have a flow from Engineer 0005585 trying to claim Backdoor Combat Factory 0003837
10/14/2019 10:21:14 AM Setting up the line; we are spending 49.9267578125 this Sim-Step
10/14/2019 10:21:14 AM I have a flow from Engineer 0005586 trying to claim Backdoor Combat Factory 0003837
10/14/2019 10:21:14 AM Setting up the line; we are spending 49.9267578125 this Sim-Step

But you're right, there were no visible lines generated.

When I swapped these lines
- line.TypeData = EntityLineTypeTable.Instance.RowsByHardcodedType[EntityLineHardcodedType.Claim];
+ line.TypeData = EntityLineTypeTable.Instance.RowsByHardcodedType[EntityLineHardcodedType.RepairHull]; <=== use the "repair hull" line type, which we know works

I suddenly saw the lines appearing. So something is wrong on the visualization side.

BadgerBadger

Oct 14, 2019 12:50 pm

manager   ~0053647

Note that a quick and dirty fix would be to just use the "repair hulls" visualization

Chris_McElligottPark

Oct 14, 2019 1:30 pm

administrator   ~0053652

Thanks!

* Fixed a bug where the visual line for ships claiming other ships was not displaying. Turns out an image that was once white that we were using as part of its material got changed to black at some point, thus making it effectively invisible because of the math of how the shader was run.
** We took this change to go ahead and make the claim lines more attractive in general, and they now have a cyan-greenish look to them, but double-beamed, so that they look kinda like the repair lines but still distinct

Issue History

Date Modified Username Field Change
Oct 13, 2019 5:10 pm wm46 New Issue
Oct 13, 2019 5:10 pm wm46 File Added: AAA.save
Oct 14, 2019 12:22 pm BadgerBadger Note Added: 0053645
Oct 14, 2019 12:22 pm BadgerBadger Summary Engineers can't assist in claiming support fleets => The Lines generated by Claiming an entity are not visible
Oct 14, 2019 12:22 pm BadgerBadger Description Updated
Oct 14, 2019 12:23 pm BadgerBadger Note Edited: 0053645
Oct 14, 2019 12:23 pm BadgerBadger Assigned To => Chris_McElligottPark
Oct 14, 2019 12:23 pm BadgerBadger Status new => assigned
Oct 14, 2019 12:50 pm BadgerBadger Note Added: 0053647
Oct 14, 2019 1:30 pm Chris_McElligottPark Status assigned => resolved
Oct 14, 2019 1:30 pm Chris_McElligottPark Resolution open => fixed
Oct 14, 2019 1:30 pm Chris_McElligottPark Fixed in Version => 0.950 First Press Build
Oct 14, 2019 1:30 pm Chris_McElligottPark Note Added: 0053652